Change in osmo-msc[master]: MNCC: use log wrapper for call processing

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Dec 18 16:49:27 UTC 2018


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12329 )

Change subject: MNCC: use log wrapper for call processing
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/12329/3/src/libmsc/mncc_builtin.c
File src/libmsc/mncc_builtin.c:

https://gerrit.osmocom.org/#/c/12329/3/src/libmsc/mncc_builtin.c@38
PS3, Line 38: "\n"
Can you show me any examples in existing osmocom code where a log/debug helper macro prints the \n, rather than the caller/user of that macro?  I don't think so, but feel free to prove me wrong.

Intorducing this kind of inconsistency across programs/macros makes work harder for developers for no good reason.



-- 
To view, visit https://gerrit.osmocom.org/12329
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c44d7bb28f1ff895dd4f839d75840495503c916
Gerrit-Change-Number: 12329
Gerrit-PatchSet: 3
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <stsp at stsp.name>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Tue, 18 Dec 2018 16:49:27 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181218/9d087b85/attachment.htm>


More information about the gerrit-log mailing list