Change in osmo-ttcn3-hacks[master]: add MSC test for an invalid CIPHER MODE COMPLETE command

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Stefan Sperling gerrit-no-reply at lists.osmocom.org
Tue Dec 18 10:58:49 UTC 2018


Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12332 )

Change subject: add MSC test for an invalid CIPHER MODE COMPLETE command
......................................................................


Patch Set 2: Code-Review+2

> Patch Set 2: Code-Review+1
> 
> If the chosen cipher is not part of the offered ciphers, that should result in a LU reject, yes.

In that case the current behaviour seems to be correct?
Issue OS#2872 is asking for a test and a fix. Since we now have a test and the behaviour seems OK, can I simply close the issue?

> 
> But possibly, what you have tested is that A5/2 is generally deprecated and should always be rejected?
> 
> Please clarify this with another test run and then submit.

Yes the test is still passing with A5/3 instead of A5/2.


-- 
To view, visit https://gerrit.osmocom.org/12332
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4492eb7d77371aaa047abae81a2dcf26fe46eb6a
Gerrit-Change-Number: 12332
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Sperling <stsp at stsp.name>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <stsp at stsp.name>
Gerrit-Comment-Date: Tue, 18 Dec 2018 10:58:49 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181218/adf492d0/attachment.htm>


More information about the gerrit-log mailing list