Change in osmo-ttcn3-hacks[master]: add MSC test for an invalid CIPHER MODE COMPLETE command

[Stefan Sperling]

Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12332 )

Change subject: add MSC test for an invalid CIPHER MODE COMPLETE command
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.osmocom.org/#/c/12332/1/msc/MSC_Tests.ttcn
File msc/MSC_Tests.ttcn:

https://gerrit.osmocom.org/#/c/12332/1/msc/MSC_Tests.ttcn@2793
PS1, Line 2793: 		BSSAP.send(ts_BSSMAP_CipherModeCompl(int2oct(3 /* "accept" A5/3 */, 1)));
> (isn't 0x3 == A5/2? maybe I'm confusing the IEs)
Oh, right. I'll fix this, thanks!


https://gerrit.osmocom.org/#/c/12332/1/msc/MSC_Tests.ttcn@2820
PS1, Line 2820: 	f_vty_config(MSCVTY, "network", "authentication required");
> ('authentication required' is implied by enabling encryption, so you could drop this first vty cmd)
Will fix, thanks.


https://gerrit.osmocom.org/#/c/12332/1/msc/expected-results.xml
File msc/expected-results.xml:

https://gerrit.osmocom.org/#/c/12332/1/msc/expected-results.xml@72
PS1, Line 72:   <testcase classname='MSC_Tests' name='TC_cipher_complete_with_invalid_cipher' time='MASKED'/>
> from the issue i understand that the test should currently be failing? this here marks it as expecte […]
Yes it is expected to pass. As I explained in the issue, the current behaviour is that the MSC returns a LU reject, and the test has been written to expect this. I don't know how the MSC should behave in this case. I've read some parts of the spec but haven't found out about this detail yet. Any clues?



-- 
To view, visit https://gerrit.osmocom.org/12332
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4492eb7d77371aaa047abae81a2dcf26fe46eb6a
Gerrit-Change-Number: 12332
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling <stsp at stsp.name>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <stsp at stsp.name>
Gerrit-Comment-Date: Mon, 17 Dec 2018 15:37:01 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181217/796794e7/attachment.htm>