This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Pau Espin Pedrol gerrit-no-reply at lists.osmocom.orgPau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12268 ) Change subject: add to osmo_sock_get_name*() API ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/12268/1/include/osmocom/core/socket.h File include/osmocom/core/socket.h: https://gerrit.osmocom.org/#/c/12268/1/include/osmocom/core/socket.h@64 PS1, Line 64: int osmo_sock_get_name2_buf(char *str, size_t str_len, int fd); > there is a 2? You mean it should be in the end instead? […] I mean it should be named osmo_sock_get_name_buf(). Let's not extend use of "2" because a similar "epic FAIL" API has it. https://gerrit.osmocom.org/#/c/12268/1/src/socket.c File src/socket.c: https://gerrit.osmocom.org/#/c/12268/1/src/socket.c@796 PS1, Line 796: * \param[out] str Destination string buffer. > you mean the indent? I'm just copying the scheme I find around here. […] Well since a variable in C cannot contain a space, it makes no sense to me to add an extra space, it's obvious the var ends at whitespace boundary, so no need to add 2 of them. -- To view, visit https://gerrit.osmocom.org/12268 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8ad89ac447c9c582742e70d082072bdd40a5a398 Gerrit-Change-Number: 12268 Gerrit-PatchSet: 1 Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Comment-Date: Mon, 17 Dec 2018 14:39:33 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181217/afe4aebb/attachment.htm>