Change in osmo-bts[master]: rsl: Send PDCH ACT NACK if TCH chan is still active

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12180 )

Change subject: rsl: Send PDCH ACT NACK if TCH chan is still active
......................................................................


Patch Set 1:

(1 comment)

my +1 is already here, need someone else now.

It's still hard to navigate why exactly this patch is needed though.
I assume that you're doing the right thing, but it is not very clearly explained. Good enough for me, but that may be the reason why there is only one vote so far.

https://gerrit.osmocom.org/#/c/12180/1/src/common/rsl.c
File src/common/rsl.c:

https://gerrit.osmocom.org/#/c/12180/1/src/common/rsl.c@2207
PS1, Line 2207: 		/* TCH takes preference over PDCH so allow forcing PDCH DEACT,
> From looking at BTS code, it looks like PDCH in general is expected to be !NONE too, but I didn't go […]
(TBF activity never has any impact on osmo-bts, it just hands off all control to the PCU)



-- 
To view, visit https://gerrit.osmocom.org/12180
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6d6d12aec10c801fe55012ca6e58d0bc8755b15d
Gerrit-Change-Number: 12180
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Assignee: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 17 Dec 2018 14:19:22 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181217/996479a8/attachment.htm>