Change in libosmocore[master]: vty: Introduce telnet_init_default and make vty port configurable

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Mon Dec 17 13:57:53 UTC 2018


Max has posted comments on this change. ( https://gerrit.osmocom.org/12321 )

Change subject: vty: Introduce telnet_init_default and make vty port configurable
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

Please clarify why signed values are used for port which starts from 0.

https://gerrit.osmocom.org/#/c/12321/1/include/osmocom/vty/vty.h
File include/osmocom/vty/vty.h:

https://gerrit.osmocom.org/#/c/12321/1/include/osmocom/vty/vty.h@214
PS1, Line 214: int vty_get_bind_port(int default_port);
Is there any use-case where we want to call vty_get_bind_port() with negative value?


https://gerrit.osmocom.org/#/c/12321/1/src/vty/vty.c
File src/vty/vty.c:

https://gerrit.osmocom.org/#/c/12321/1/src/vty/vty.c@1638
PS1, Line 1638: 	return default_port;
So this can return negative value only if it receives it as parameter.



-- 
To view, visit https://gerrit.osmocom.org/12321
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5fb2faaf4311bd7284ee870526a6f87b7e260f3
Gerrit-Change-Number: 12321
Gerrit-PatchSet: 1
Gerrit-Owner: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <stsp at stsp.name>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Mon, 17 Dec 2018 13:57:53 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181217/20af1d99/attachment.htm>


More information about the gerrit-log mailing list