Change in osmo-ttcn3-hacks[master]: MSC_Tests.ttcn: introduce TC_gsup_mo_smma for MO SMMA over GSUP

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Stefan Sperling gerrit-no-reply at lists.osmocom.org
Mon Dec 17 11:12:13 UTC 2018


Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11776 )

Change subject: MSC_Tests.ttcn: introduce TC_gsup_mo_smma for MO SMMA over GSUP
......................................................................


Patch Set 5: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/#/c/11776/5//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/11776/5//COMMIT_MSG@10
PS5, Line 10: over GSUP towards HLR. The algorythm is equivalent to MO SMS.
spelling: "algorithm"


https://gerrit.osmocom.org/#/c/11776/5/msc/BSC_ConnectionHandler.ttcn
File msc/BSC_ConnectionHandler.ttcn:

https://gerrit.osmocom.org/#/c/11776/5/msc/BSC_ConnectionHandler.ttcn@817
PS5, Line 817: 	/* just in case this is routed to SMPP.. */
This comment assumes the reader already knows about the consequences of routing over SMPP,
so it doesn't really explain anything. What does routing over SMPP imply?



-- 
To view, visit https://gerrit.osmocom.org/11776
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7abc95b8e416f7308d54e11be11c08586d18e6c5
Gerrit-Change-Number: 11776
Gerrit-PatchSet: 5
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Stefan Sperling <stsp at stsp.name>
Gerrit-Comment-Date: Mon, 17 Dec 2018 11:12:13 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181217/795228e6/attachment.htm>


More information about the gerrit-log mailing list