Change in osmocom-bb[master]: trx_toolkit/ctrl_if_bb.py: drop meaningless warnings

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Mon Dec 17 09:52:15 UTC 2018


Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/12291 )

Change subject: trx_toolkit/ctrl_if_bb.py: drop meaningless warnings
......................................................................

trx_toolkit/ctrl_if_bb.py: drop meaningless warnings

A timeslot can be reconfigured at runtime, this is normal.
We should neither complain nor reject such commands.

Change-Id: I0a69ebceed5aa724093e6d1b23faad8c16705055
---
M src/target/trx_toolkit/ctrl_if_bb.py
1 file changed, 0 insertions(+), 8 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/target/trx_toolkit/ctrl_if_bb.py b/src/target/trx_toolkit/ctrl_if_bb.py
index fe7f3e8..d25aa30 100644
--- a/src/target/trx_toolkit/ctrl_if_bb.py
+++ b/src/target/trx_toolkit/ctrl_if_bb.py
@@ -114,18 +114,10 @@
 				# Deactivate TS (remove from TS pass-filter list)
 				if ts in self.burst_fwd.ts_pass_list:
 					self.burst_fwd.ts_pass_list.remove(ts)
-				else:
-					log.warning("TS %u was not activated before" % ts)
-					# TODO: uncomment as soon as RESET is introduced
-					# return -1
 			else:
 				# Activate TS (add to TS pass-filter list)
 				if ts not in self.burst_fwd.ts_pass_list:
 					self.burst_fwd.ts_pass_list.append(ts)
-				else:
-					log.warning("TS %u was already activated before" % ts)
-					# TODO: uncomment as soon as RESET is introduced
-					# return -1
 
 			return 0
 

-- 
To view, visit https://gerrit.osmocom.org/12291
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0a69ebceed5aa724093e6d1b23faad8c16705055
Gerrit-Change-Number: 12291
Gerrit-PatchSet: 3
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-CC: Max <msuraev at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181217/28a310e0/attachment.htm>


More information about the gerrit-log mailing list