Change in osmocom-bb[master]: trx_toolkit: fix missing / useless imports

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Mon Dec 17 07:02:58 UTC 2018


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/12322 )

Change subject: trx_toolkit: fix missing / useless imports
......................................................................

trx_toolkit: fix missing / useless imports

Found using Flake8:

  - data_if.py:57:4: F405 'log' may be undefined, or defined
                     from star imports: data_msg
  - clck_gen.py:29:1: F401 'time' imported but unused
  - clck_gen.py:30:1: F401 'sys' imported but unused
  - trx_sniff.py:28:1: F401 'signal' imported but unused

Change-Id: Id0c42319b445db218b77fd5e99a9a0a89724281d
---
M src/target/trx_toolkit/burst_send.py
M src/target/trx_toolkit/clck_gen.py
M src/target/trx_toolkit/data_if.py
M src/target/trx_toolkit/trx_sniff.py
4 files changed, 2 insertions(+), 4 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/target/trx_toolkit/burst_send.py b/src/target/trx_toolkit/burst_send.py
index 3745b39..0cf63bb 100755
--- a/src/target/trx_toolkit/burst_send.py
+++ b/src/target/trx_toolkit/burst_send.py
@@ -32,7 +32,6 @@
 from app_common import ApplicationBase
 from data_dump import DATADumpFile
 from data_if import DATAInterface
-from gsm_shared import *
 from data_msg import *
 
 class Application(ApplicationBase):
diff --git a/src/target/trx_toolkit/clck_gen.py b/src/target/trx_toolkit/clck_gen.py
index 40964dd..6c2cbf8 100755
--- a/src/target/trx_toolkit/clck_gen.py
+++ b/src/target/trx_toolkit/clck_gen.py
@@ -26,8 +26,6 @@
 
 import logging as log
 import signal
-import time
-import sys
 
 from app_common import ApplicationBase
 from threading import Timer
diff --git a/src/target/trx_toolkit/data_if.py b/src/target/trx_toolkit/data_if.py
index 45114ed..79584da 100644
--- a/src/target/trx_toolkit/data_if.py
+++ b/src/target/trx_toolkit/data_if.py
@@ -22,6 +22,8 @@
 # with this program; if not, write to the Free Software Foundation, Inc.,
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
+import logging as log
+
 from udp_link import UDPLink
 from data_msg import *
 
diff --git a/src/target/trx_toolkit/trx_sniff.py b/src/target/trx_toolkit/trx_sniff.py
index e169c72..19ea8e6 100755
--- a/src/target/trx_toolkit/trx_sniff.py
+++ b/src/target/trx_toolkit/trx_sniff.py
@@ -25,7 +25,6 @@
 APP_CR_HOLDERS = [("2018", "Vadim Yanitskiy <axilirator at gmail.com>")]
 
 import logging as log
-import signal
 import argparse
 import sys
 

-- 
To view, visit https://gerrit.osmocom.org/12322
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id0c42319b445db218b77fd5e99a9a0a89724281d
Gerrit-Change-Number: 12322
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181217/1ef8e351/attachment.htm>


More information about the gerrit-log mailing list