This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/12088 ) Change subject: configure.ac: check boost only if USRP1 support is enabled ...................................................................... configure.ac: check boost only if USRP1 support is enabled boost is only used in USRPDevice class. It looks like it can be removed entirely quite easily, since only boost::shared_ptr is used for 2 variables. That's left for somebody with the device and willingness to test the changes. Change-Id: I4c3fa3ff58fd552d0cb4c4cf2033615d84c07c96 --- M configure.ac 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Harald Welte: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/configure.ac b/configure.ac index 37b70fa..2ce4462 100644 --- a/configure.ac +++ b/configure.ac @@ -155,6 +155,8 @@ ]) AS_IF([test "x$with_usrp1" = "xyes"], [ + AC_CHECK_HEADER([boost/config.hpp],[], + [AC_MSG_ERROR([boost/config.hpp not found, install e.g. libboost-dev])]) PKG_CHECK_MODULES(USRP, usrp >= 3.3) ]) @@ -234,9 +236,6 @@ PKG_CHECK_MODULES(LIBUSB, libusb-1.0) PKG_CHECK_MODULES(FFTWF, fftw3f) -AC_CHECK_HEADER([boost/config.hpp],[], - [AC_MSG_ERROR([boost/config.hpp not found, install e.g. libboost-dev])]) - # Generate manuals AC_ARG_ENABLE(manuals, [AS_HELP_STRING( -- To view, visit https://gerrit.osmocom.org/12088 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I4c3fa3ff58fd552d0cb4c4cf2033615d84c07c96 Gerrit-Change-Number: 12088 Gerrit-PatchSet: 2 Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-CC: Neels Hofmeyr <nhofmeyr at sysmocom.de> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181214/29b0aa21/attachment.htm>