Change in osmo-sysmon[master]: Use absolute path for default config

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Fri Dec 14 16:00:41 UTC 2018


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12319 )

Change subject: Use absolute path for default config
......................................................................


Patch Set 1:

> > Patch Set 1: Code-Review-1
 > >
 > > As far as I can tell, in all repos we have default cfg_file as
 > $CWD/*.cfg, so I'd rather keep same behavior for all osmocom
 > projects.
 > >
 > > Another discussion is whether we want to move all osmocom
 > projects to have /etc/osmocom/*.cfg by default. It'd then make
 > sense to by default check first $CWD and if not found look for
 > /etc/osmocom, to maintain it backwards-compatible.
 > 
 > The plan is to use this as login shell and I'm not sure what's $CWD
 > in this case so it's better to use absolute path.

Login shell has already been added through a script, so no issue with that. Let's keep the default file like in all other osmocom projects.


-- 
To view, visit https://gerrit.osmocom.org/12319
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sysmon
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37c559af99872de9290335699e2118924ae2156a
Gerrit-Change-Number: 12319
Gerrit-PatchSet: 1
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 14 Dec 2018 16:00:41 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181214/cbe05ca7/attachment.htm>


More information about the gerrit-log mailing list