Change in osmo-msc[master]: libmsc/gsm_09_11.c: implement guard timer for NCSS sessions

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11992 )

Change subject: libmsc/gsm_09_11.c: implement guard timer for NCSS sessions
......................................................................


Patch Set 7:

(3 comments)

https://gerrit.osmocom.org/#/c/11992/7/include/osmocom/msc/gsm_data.h
File include/osmocom/msc/gsm_data.h:

https://gerrit.osmocom.org/#/c/11992/7/include/osmocom/msc/gsm_data.h@188
PS7, Line 188: 	int ncss_guard_timeout;
> Why do you use int in here?
Same as mncc_guard_timeout. Integer is expected by libosmocore:

  void osmo_timer_schedule(struct osmo_timer_list *timer, int seconds, int microseconds);

We can change it in a separate change. Not critical.


https://gerrit.osmocom.org/#/c/11992/7/src/libmsc/gsm_09_11.c
File src/libmsc/gsm_09_11.c:

https://gerrit.osmocom.org/#/c/11992/7/src/libmsc/gsm_09_11.c@477
PS7, Line 477: 	if (net->ncss_guard_timeout > 0) {
> Seems like we always check ncss_guard_timeout > 0
Because it's optional. What's wrong with that?


https://gerrit.osmocom.org/#/c/11992/7/src/libmsc/msc_vty.c
File src/libmsc/msc_vty.c:

https://gerrit.osmocom.org/#/c/11992/7/src/libmsc/msc_vty.c@382
PS7, Line 382:       "guard timer value (sec.), or 0 to disable\n")
> So ncss_guard_timeout is always positive and fit into uint8_t.
Please see my comment above.



-- 
To view, visit https://gerrit.osmocom.org/11992
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf4d87c45e90324764073e8230e0fb9cb96dd9cb
Gerrit-Change-Number: 11992
Gerrit-PatchSet: 7
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Fri, 14 Dec 2018 13:34:46 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181214/73b64f47/attachment.htm>