Change in libosmocore[master]: GSUP/SMS: introduce MO-/MT-FORWARD-SM messages

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Stefan Sperling gerrit-no-reply at lists.osmocom.org
Fri Dec 14 12:54:57 UTC 2018


Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11069 )

Change subject: GSUP/SMS: introduce MO-/MT-FORWARD-SM messages
......................................................................


Patch Set 11: Code-Review+1

(3 comments)

https://gerrit.osmocom.org/#/c/11069/11/src/gsm/gsup.c
File src/gsm/gsup.c:

https://gerrit.osmocom.org/#/c/11069/11/src/gsm/gsup.c@668
PS11, Line 668: 				sizeof(u8), gsup_msg->sm_rp_mr);
Use sizeof(*gsup_msg->sm_rp_mr) here?


https://gerrit.osmocom.org/#/c/11069/11/src/gsm/gsup.c@694
PS11, Line 694: 				sizeof(u8), gsup_msg->sm_rp_mms);
Use sizeof(*gsup_msg->sm_rp_mms)?


https://gerrit.osmocom.org/#/c/11069/11/src/gsm/gsup.c@699
PS11, Line 699: 				sizeof(u8), gsup_msg->sm_rp_cause);
Use sizeof(*gsup_msg->sm_rp_cause)?



-- 
To view, visit https://gerrit.osmocom.org/11069
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe325c64ae2d6c626b232533bb4cbc65fc2b5d71
Gerrit-Change-Number: 11069
Gerrit-PatchSet: 11
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <stsp at stsp.name>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Fri, 14 Dec 2018 12:54:57 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181214/0efb6906/attachment.htm>


More information about the gerrit-log mailing list