Change in osmocom-bb[master]: trx_toolkit/ctrl_if_trx.py: drop meaningless warnings

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Fri Dec 14 12:52:57 UTC 2018


Max has posted comments on this change. ( https://gerrit.osmocom.org/12291 )

Change subject: trx_toolkit/ctrl_if_trx.py: drop meaningless warnings
......................................................................


Patch Set 2:

(1 comment)

Could you clarify in commit message if RESET was introduced or why removing this TODO is the right thing.

https://gerrit.osmocom.org/#/c/12291/2/src/target/trx_toolkit/ctrl_if_trx.py
File src/target/trx_toolkit/ctrl_if_trx.py:

https://gerrit.osmocom.org/#/c/12291/2/src/target/trx_toolkit/ctrl_if_trx.py@a126
PS2, Line 126: 
That's rather puzzling TODO in here.



-- 
To view, visit https://gerrit.osmocom.org/12291
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a69ebceed5aa724093e6d1b23faad8c16705055
Gerrit-Change-Number: 12291
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: Max <msuraev at sysmocom.de>
Gerrit-Comment-Date: Fri, 14 Dec 2018 12:52:57 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181214/b7a74d83/attachment.htm>


More information about the gerrit-log mailing list