Change in libosmocore[master]: GSUP/SMS: introduce READY-FOR-SM message

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11751 )

Change subject: GSUP/SMS: introduce READY-FOR-SM message
......................................................................


Patch Set 6:

(2 comments)

https://gerrit.osmocom.org/#/c/11751/6/src/gsm/gsup.c
File src/gsm/gsup.c:

https://gerrit.osmocom.org/#/c/11751/6/src/gsm/gsup.c@710
PS6, Line 710: 	if ((u8 = gsup_msg->sm_alert_rsn)) {
> A follow-up suggestion: […]
Well, this approach is quite common, look at:

  - gsup_msg->cause,
  - gsup_msg->cancel_type,

where this check is also done implicitly.

Any benefits of checking this explicitly?


https://gerrit.osmocom.org/#/c/11751/6/src/gsm/gsup.c@710
PS6, Line 710: 	if ((u8 = gsup_msg->sm_alert_rsn)) {
> This check for non-zero means OSMO_GSUP_SMS_SM_ALERT_RSN_NONE won't ever be sent. […]
Yes, correct. The current GSUP API in libosmocore is ugly, because
we have a single structure for all kinds of messages. This is why
we have to introduce such special values.



-- 
To view, visit https://gerrit.osmocom.org/11751
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic37f3b2114b8095cfce22977e67133b9103942e3
Gerrit-Change-Number: 11751
Gerrit-PatchSet: 6
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Stefan Sperling <stsp at stsp.name>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Fri, 14 Dec 2018 12:51:07 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181214/1b0e6de8/attachment.htm>