Change in osmo-sgsn[master]: make gsup ipa name configurable in osmo-sgsn.cfg

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Stefan Sperling gerrit-no-reply at lists.osmocom.org
Fri Dec 14 11:46:41 UTC 2018


Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12243 )

Change subject: make gsup ipa name configurable in osmo-sgsn.cfg
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/#/c/12243/3/src/gprs/sgsn_vty.c
File src/gprs/sgsn_vty.c:

https://gerrit.osmocom.org/#/c/12243/3/src/gprs/sgsn_vty.c@1454
PS3, Line 1454: 	parsing_config_file = true;
> Why initializing it here instead of where it's declared?
At present what you suggest would of course be equivalent, but code evolves over time. If we set the flag to true during program init already, then the flag's effect might change if calls into the VTY code made during program startup are ever changed in the future.
This flag should only be set while vty_read_ocnfig_file is running, so setting it before and after calling this function makes that very explicit. Should I add a comment which mentions this?



-- 
To view, visit https://gerrit.osmocom.org/12243
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2f65fed9f56b9718e8a9647e3f01dce69870c1f
Gerrit-Change-Number: 12243
Gerrit-PatchSet: 3
Gerrit-Owner: Stefan Sperling <stsp at stsp.name>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <stsp at stsp.name>
Gerrit-Comment-Date: Fri, 14 Dec 2018 11:46:41 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181214/57830432/attachment.htm>


More information about the gerrit-log mailing list