Change in libosmocore[master]: gsm0480: fix copy-pasted note for gsm0480_gen_return_error()

[Vadim Yanitskiy]

Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/11988 )

Change subject: gsm0480: fix copy-pasted note for gsm0480_gen_return_error()
......................................................................

gsm0480: fix copy-pasted note for gsm0480_gen_return_error()

InvokeID is mandatory for ReturnError component.

Change-Id: Ie1c7116d368c2029b9f524cb74ffa316e282ec83
---
M src/gsm/gsm0480.c
1 file changed, 0 insertions(+), 3 deletions(-)

Approvals:
  Vadim Yanitskiy: Looks good to me, approved
  Pau Espin Pedrol: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/gsm/gsm0480.c b/src/gsm/gsm0480.c
index 021db62..fab2087 100644
--- a/src/gsm/gsm0480.c
+++ b/src/gsm/gsm0480.c
@@ -847,9 +847,6 @@
  * \param[in] invoke_id		InvokeID of the request
  * \param[in] error_code	Error code (section 4.5)
  * \return			message buffer containing the Reject component
- *
- * Note: if InvokeID is not available, e.g. when message parsing failed, any incorrect vlue
- * can be passed (0x00 > x > 0xff), so the universal NULL-tag (see table 3.6) will be used instead.
  */
 struct msgb *gsm0480_gen_return_error(uint8_t invoke_id, uint8_t error_code)
 {

-- 
To view, visit https://gerrit.osmocom.org/11988
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie1c7116d368c2029b9f524cb74ffa316e282ec83
Gerrit-Change-Number: 11988
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181214/1034eed0/attachment.htm>