Change in osmo-msc[master]: require 'ipa-name' option to be set via config file

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Thu Dec 13 11:01:01 UTC 2018


Max has posted comments on this change. ( https://gerrit.osmocom.org/12293 )

Change subject: require 'ipa-name' option to be set via config file
......................................................................


Patch Set 1:

(2 comments)

That's a minor note though - mostly commenting just in case I need the same thing for some config option in future :)

https://gerrit.osmocom.org/#/c/12293/1/src/osmo-msc/msc_main.c
File src/osmo-msc/msc_main.c:

https://gerrit.osmocom.org/#/c/12293/1/src/osmo-msc/msc_main.c@518
PS1, Line 518: bool msc_parsing_config_file = false;
Why not initialize it with true to begin with?


https://gerrit.osmocom.org/#/c/12293/1/src/osmo-msc/msc_main.c@572
PS1, Line 572: 	msc_parsing_config_file = true;
So, here it's set to true.



-- 
To view, visit https://gerrit.osmocom.org/12293
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6cff91793e646e0396e8f1bc87d0f52709e5f12a
Gerrit-Change-Number: 12293
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling <stsp at stsp.name>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: Max <msuraev at sysmocom.de>
Gerrit-Comment-Date: Thu, 13 Dec 2018 11:01:01 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181213/b1cbefec/attachment.htm>


More information about the gerrit-log mailing list