This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Pau Espin Pedrol gerrit-no-reply at lists.osmocom.orgPau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12287 ) Change subject: osmo-bts-trx/loops.c: Add comments documenting TA + MS power control loop ...................................................................... Patch Set 1: Code-Review+1 (3 comments) https://gerrit.osmocom.org/#/c/12287/1/src/osmo-bts-trx/loops.c File src/osmo-bts-trx/loops.c: https://gerrit.osmocom.org/#/c/12287/1/src/osmo-bts-trx/loops.c@41 PS1, Line 41: * \param lchan logical channel for which to compute (and in whihc to store) new power. typo: which "new power value" seems more appropiate. Probably also add: "new power value from previous value" https://gerrit.osmocom.org/#/c/12287/1/src/osmo-bts-trx/loops.c@52 PS1, Line 52: /* compute new target MS output power level based on current value subtracted by 'diff/2' */ s/current/previous would be more easy to catch. current may refer to new or old one. Perhaps you want to explain somehow why diff/2. I think it's because we use steps of 2dB as granularity? https://gerrit.osmocom.org/#/c/12287/1/src/osmo-bts-trx/loops.c@64 PS1, Line 64: if (arfcn >= 512 && arfcn <= 885) { Not directly related, but: this code looks like a good candidate to be a separate function and perhaps in libosmogsm? osmo_max_power_ms_by_band() or similar. -- To view, visit https://gerrit.osmocom.org/12287 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iafea07eb751ed85d29b214576bb0d31ea919cd72 Gerrit-Change-Number: 12287 Gerrit-PatchSet: 1 Gerrit-Owner: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Comment-Date: Thu, 13 Dec 2018 10:58:16 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181213/29487953/attachment.htm>