This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11690 ) Change subject: MSC_Tests: remove unused control interface ...................................................................... Patch Set 8: Code-Review-1 > (1 comment) > > > I mean, it would be nicer to allow having a ctrl for both sides, > > but if it fixes the status quo, this patch is ok, right? > > Making the control interface available from both sides requires an > additional architecture to route the message back and forth between > the two entities. I'm not sure I'm following you here. Why would two components not be able to each independently talk to the CTRL interface? Where exactly is the problem here? Where is what kind of "architecture" needed? > The patch does not break anything, also having the control > interface available at the BSC_ConnectionHandler makes more sense > than having it on the MTC_CT. For your particular use case right now, this may be true. For other use cases, it is different. I put it there intentionally at a time. As other test suites also show, for some tests it makes sense to access CTRL or VTY from the main test component,and for others from the respective *Handler. There's no one truth here. -- To view, visit https://gerrit.osmocom.org/11690 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I204b2e96057d13342f4bd4fdaf08fb7b88b6b11d Gerrit-Change-Number: 11690 Gerrit-PatchSet: 8 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-Comment-Date: Wed, 12 Dec 2018 20:57:18 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181212/5ce3bf3a/attachment.htm>