This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Max gerrit-no-reply at lists.osmocom.orgMax has posted comments on this change. ( https://gerrit.osmocom.org/12242 ) Change subject: remove pointless declaration of struct gsm_network ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/12242/1/src/gprs/sgsn_ctrl.c File src/gprs/sgsn_ctrl.c: https://gerrit.osmocom.org/#/c/12242/1/src/gprs/sgsn_ctrl.c@64 PS1, Line 64: struct ctrl_handle *sgsn_controlif_setup(void *data, const char *bind_addr, uint16_t port) > I think it's even more confusing this way. If parameter is unused than simply drop the parameter. In fact, entire function is trivial one-line wrapper used in single place. Better drop it completely and just call ctrl_interface_setup_dynip() directly from main(). -- To view, visit https://gerrit.osmocom.org/12242 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib4151afa5bff01e63b462cca517fb60ac0503759 Gerrit-Change-Number: 12242 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Sperling <stsp at stsp.name> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Stefan Sperling <stsp at stsp.name> Gerrit-Comment-Date: Wed, 12 Dec 2018 09:56:26 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181212/85a72451/attachment.htm>