Change in osmo-ttcn3-hacks[master]: MGCP: remove commented variants

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Dec 11 21:07:40 UTC 2018


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/12238 )

Change subject: MGCP: remove commented variants
......................................................................

MGCP: remove commented variants

It's unclear why those variants were commented - looks like artifact
from initial development. Let's drop them to avoid confusion.

Change-Id: I3f11a93634fc50243a7210edcd501bd4b90d6dcd
---
M library/MGCP_Types.ttcn
1 file changed, 0 insertions(+), 3 deletions(-)

Approvals:
  Pau Espin Pedrol: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/library/MGCP_Types.ttcn b/library/MGCP_Types.ttcn
index 6bb266e..8e11c7a 100644
--- a/library/MGCP_Types.ttcn
+++ b/library/MGCP_Types.ttcn
@@ -53,7 +53,6 @@
 		MgcpVersion	ver
 	} with {
 		variant "SEPARATOR(' ', '[\t ]+')"
-		//variant "END('\r\n', '(\n)|(\r\n)')"
 		variant "END('\r\n', '([\r\n])|(\r\n)')"
 	}
 
@@ -63,7 +62,6 @@
 	} with {
 		variant "BEGIN('')"
 		variant "SEPARATOR(': ', ':[\t ]+')"
-		//variant "END('\r\n', '(\n)|(\r\n)')"
 		variant "END('\r\n', '([\r\n])|(\r\n)')"
 	}
 
@@ -91,7 +89,6 @@
 		charstring		string optional
 	} with {
 		variant "SEPARATOR(' ', '[\t ]+')"
-		//variant "END('\r\n', '(\n)|(\r\n)')"
 		variant "END('\r\n', '([\r\n])|(\r\n)')"
 	}
 

-- 
To view, visit https://gerrit.osmocom.org/12238
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3f11a93634fc50243a7210edcd501bd4b90d6dcd
Gerrit-Change-Number: 12238
Gerrit-PatchSet: 3
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181211/36917bc2/attachment.htm>


More information about the gerrit-log mailing list