Change in libosmo-sccp[master]: clarify fixme comment, x7

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Tue Dec 11 12:12:55 UTC 2018


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/228 )

Change subject: clarify fixme comment, x7
......................................................................


Patch Set 3:

(1 comment)

(posting forgotten Draft comments, may be hoplessly outdated now. Easiest to get rid of them is to just "Reply", so bear with me, thx)

https://gerrit.osmocom.org/#/c/228/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/228/1//COMMIT_MSG@7
PS1, Line 7: 
> why is it obsolete? are we now generating an error message towards the remote side?
I assumed the "LOGP(DSUA, LOGL_ERROR," was the error message :)



-- 
To view, visit https://gerrit.osmocom.org/228
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6de8fb202c7beb025232e9b97605e9f46778506a
Gerrit-Change-Number: 228
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Tue, 11 Dec 2018 12:12:55 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181211/b4f02f20/attachment.htm>


More information about the gerrit-log mailing list