This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgNeels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/4337 ) Change subject: Replace bitvec_set_uint() with bitvec_set_u64() ...................................................................... Patch Set 4: (1 comment) (posting forgotten Draft comments, may be hoplessly outdated now. Easiest to get rid of them is to just "Reply", so bear with me, thx) https://gerrit.osmocom.org/#/c/4337/1/include/osmocom/core/bitvec.h File include/osmocom/core/bitvec.h: https://gerrit.osmocom.org/#/c/4337/1/include/osmocom/core/bitvec.h@74 PS1, Line 74: int bitvec_write_field(struct bitvec *bv, unsigned int *write_index, uint64_t val, unsigned int len); there already is a uint64_t writing function all the while? Is the point adding the lh in the first place? If yes please say so in the commit log! -- To view, visit https://gerrit.osmocom.org/4337 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1b670dacb55fb3063271d045f9faa10fccba10a6 Gerrit-Change-Number: 4337 Gerrit-PatchSet: 4 Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Minh-Quang Nguyen <minh-quang.nguyen at nutaq.com> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Comment-Date: Tue, 11 Dec 2018 12:10:50 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181211/efb4b1ca/attachment.htm>