Change in osmo-mgw[master]: mgcp client: vty: tweak doc strings

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Tue Dec 11 12:08:46 UTC 2018


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/4598 )

Change subject: mgcp client: vty: tweak doc strings
......................................................................


Patch Set 4:

(1 comment)

(posting forgotten Draft comments, may be hoplessly outdated now. Easiest to get rid of them is to just "Reply", so bear with me, thx)

https://gerrit.osmocom.org/#/c/4598/1/src/libosmo-mgcp-client/mgcp_client_vty.c
File src/libosmo-mgcp-client/mgcp_client_vty.c:

https://gerrit.osmocom.org/#/c/4598/1/src/libosmo-mgcp-client/mgcp_client_vty.c@76
PS1, Line 76: 	OSMO_ASSERT(global_mgcp_client_ctx);
> both MGCP and RTP are UDP, so TCP is wrong, IMHO
argh, I'll just drop the TCP then



-- 
To view, visit https://gerrit.osmocom.org/4598
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1a408f9e651c5fb3424a84ceaaa603e20ad595c
Gerrit-Change-Number: 4598
Gerrit-PatchSet: 4
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Tue, 11 Dec 2018 12:08:46 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181211/2e9b5461/attachment.htm>


More information about the gerrit-log mailing list