Change in osmo-bsc[master]: abisip-find: add getopts and option to prevent endless loop

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/5239 )

Change subject: abisip-find: add getopts and option to prevent endless loop
......................................................................


Patch Set 2:

(1 comment)

(posting forgotten Draft comments, may be hoplessly outdated now. Easiest to get rid of them is to just "Reply", so bear with me, thx)

https://gerrit.osmocom.org/#/c/5239/2/src/ipaccess/abisip-find.c
File src/ipaccess/abisip-find.c:

https://gerrit.osmocom.org/#/c/5239/2/src/ipaccess/abisip-find.c@199
PS2, Line 199: 	printf("  -i --ifname. Specify outgoing interface\n");
-1: let's not change the semantics for the network interface, i.e. still handle the interface name as a positional argument without a dash-option. There is no need to break the way it previously worked, is there?

(an example of this that comes to mind is osmo-hlr-db-tool which has e.g. 'create' as such positional argument, so you could look up positional arg handling in that code.)



-- 
To view, visit https://gerrit.osmocom.org/5239
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I819b9616282dd6efd36c9557c7d6a50b6b00cdc2
Gerrit-Change-Number: 5239
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-CC: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Tue, 11 Dec 2018 12:08:33 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181211/fcda871d/attachment.htm>