Change in osmo-msc[master]: tweak comment to indicate sub_pres_vlr fsm as dead code

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Tue Dec 11 11:38:26 UTC 2018


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12234 )

Change subject: tweak comment to indicate sub_pres_vlr fsm as dead code
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/12234/2/src/libvlr/vlr_lu_fsm.c
File src/libvlr/vlr_lu_fsm.c:

https://gerrit.osmocom.org/#/c/12234/2/src/libvlr/vlr_lu_fsm.c@274
PS2, Line 274: /* THIS IS CURRENTLY DEAD CODE, SINCE WE NEVER SET vsub->ms_not_reachable_flag = true.
Probably also good to state the same in the callers.



-- 
To view, visit https://gerrit.osmocom.org/12234
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I198d442e9ed288f37c7d4e5ec87b82dc53114e99
Gerrit-Change-Number: 12234
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Stefan Sperling <stsp at stsp.name>
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 11 Dec 2018 11:38:26 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181211/9d77ec7b/attachment.htm>


More information about the gerrit-log mailing list