Change in osmo-ttcn3-hacks[master]: MGCP: fix pattern warning

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Tue Dec 11 09:55:50 UTC 2018


Max has uploaded this change for review. ( https://gerrit.osmocom.org/12237


Change subject: MGCP: fix pattern warning
......................................................................

MGCP: fix pattern warning

Remove implied \r to fix following warnings:
"Duplicate character `\r' in the character set. Please note the \n
includes the \r implicitly. Use \q{0,0,0,10} if you would like to match
the LF only."

Change-Id: I99948e4b82b5b4bd5b8f7c1a4c60a97fcab3c0eb
---
M library/MGCP_Types.ttcn
1 file changed, 5 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/37/12237/1

diff --git a/library/MGCP_Types.ttcn b/library/MGCP_Types.ttcn
index 6bb266e..324ed57 100644
--- a/library/MGCP_Types.ttcn
+++ b/library/MGCP_Types.ttcn
@@ -54,7 +54,7 @@
 	} with {
 		variant "SEPARATOR(' ', '[\t ]+')"
 		//variant "END('\r\n', '(\n)|(\r\n)')"
-		variant "END('\r\n', '([\r\n])|(\r\n)')"
+		variant "END('\n', '([\n])|(\n)')"
 	}
 
 	type record MgcpParameter {
@@ -64,7 +64,7 @@
 		variant "BEGIN('')"
 		variant "SEPARATOR(': ', ':[\t ]+')"
 		//variant "END('\r\n', '(\n)|(\r\n)')"
-		variant "END('\r\n', '([\r\n])|(\r\n)')"
+		variant "END('\n', '([\n])|(\n)')"
 	}
 
 	type set of MgcpParameter MgcpParameterList with {
@@ -77,7 +77,7 @@
 		SDP_Message		sdp optional
 	} with {
 		variant "BEGIN('')"
-		variant (sdp) "BEGIN('\r\n','([\r\n])|(\r\n)')"
+		variant (sdp) "BEGIN('\n','([\n])|(\n)')"
 	}
 
 	external function enc_MgcpCommand(in MgcpCommand id) return charstring
@@ -92,7 +92,7 @@
 	} with {
 		variant "SEPARATOR(' ', '[\t ]+')"
 		//variant "END('\r\n', '(\n)|(\r\n)')"
-		variant "END('\r\n', '([\r\n])|(\r\n)')"
+		variant "END('\n', '([\n])|(\n)')"
 	}
 
 	type record MgcpResponse {
@@ -101,7 +101,7 @@
 		SDP_Message		sdp optional
 	} with {
 		variant "BEGIN('')"
-		variant (sdp) "BEGIN('\r\n','([\r\n])|(\r\n)')"
+		variant (sdp) "BEGIN('\n','([\n])|(\n)')"
 	}
 
 	external function enc_MgcpResponse(in MgcpResponse id) return charstring

-- 
To view, visit https://gerrit.osmocom.org/12237
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I99948e4b82b5b4bd5b8f7c1a4c60a97fcab3c0eb
Gerrit-Change-Number: 12237
Gerrit-PatchSet: 1
Gerrit-Owner: Max <msuraev at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181211/4697f1e9/attachment.htm>


More information about the gerrit-log mailing list