Change in osmo-sgsn[master]: Add tests for IMSI ACLs

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Mon Dec 10 18:01:18 UTC 2018


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12226 )

Change subject: Add tests for IMSI ACLs
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/#/c/12226/3/include/osmocom/sgsn/gprs_sgsn.h
File include/osmocom/sgsn/gprs_sgsn.h:

https://gerrit.osmocom.org/#/c/12226/3/include/osmocom/sgsn/gprs_sgsn.h@466
PS3, Line 466: size_t sgsn_acl_count(const struct sgsn_config *cfg);
unrelated whitespace.


https://gerrit.osmocom.org/#/c/12226/2/tests/sgsn/sgsn_test.c
File tests/sgsn/sgsn_test.c:

https://gerrit.osmocom.org/#/c/12226/2/tests/sgsn/sgsn_test.c@1343
PS2, Line 1343: 	size_t old = sgsn_acl_count(cfg), new;
> That's pretty common code patern both in osmocom and other projects - I don't see anything ugly abou […]
Doing these stuff while having another variable after calling the function separate by a comma? Let me doubt so (and if there's any place like that it should be cleaned up).



-- 
To view, visit https://gerrit.osmocom.org/12226
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia782f12b49bed6428bc9b9f513237e4e6aefdec9
Gerrit-Change-Number: 12226
Gerrit-PatchSet: 2
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 10 Dec 2018 18:01:18 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181210/6c6ac8b2/attachment.htm>


More information about the gerrit-log mailing list