This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Stefan Sperling gerrit-no-reply at lists.osmocom.orgStefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12228 ) Change subject: disable recording of LU timestamps by default ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/12228/3/src/db_hlr.c File src/db_hlr.c: https://gerrit.osmocom.org/#/c/12228/3/src/db_hlr.c@688 PS3, Line 688: db_remove_reset(stmt); > This looks weird. […] Yes it looks weird, but it is correct. Is it OK to run other statements before the most recently used statement has been reset? If so we could simplify this code. Otherwise, moving some code into a function has the downside that the 'goto out:' doesn't work anymore for the code which was moved to the function. -- To view, visit https://gerrit.osmocom.org/12228 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2f18b5ddc9b4b8e1174c6dea71cddf1c8d2230df Gerrit-Change-Number: 12228 Gerrit-PatchSet: 3 Gerrit-Owner: Stefan Sperling <stsp at stsp.name> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Stefan Sperling <stsp at stsp.name> Gerrit-Comment-Date: Mon, 10 Dec 2018 17:42:22 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181210/c72b4c71/attachment.htm>