Change in osmo-bsc[master]: gsm_04_08: Free GSM subscr conn if paging response can't be matched

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Dec 6 19:51:21 UTC 2018


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/12174 )

Change subject: gsm_04_08: Free GSM subscr conn if paging response can't be matched
......................................................................

gsm_04_08: Free GSM subscr conn if paging response can't be matched

The current idea of calling gscon_release_lchans is not enough because
the conn is still present.
Insetad pretend we got a disconnect indication from the MSC which will
call gscon_release_lchans as well as terminate the conn state machine
which will clean up conn state as well.

Related: OS#3680
Change-Id: Iccf5f6864ffe238189907c4bb3ea333948621b4c
---
M src/osmo-bsc/gsm_04_08_rr.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bsc/gsm_04_08_rr.c b/src/osmo-bsc/gsm_04_08_rr.c
index 4be5198..f1061ef 100644
--- a/src/osmo-bsc/gsm_04_08_rr.c
+++ b/src/osmo-bsc/gsm_04_08_rr.c
@@ -951,7 +951,7 @@
 		/* fwd via bsc_api to send COMPLETE L3 INFO to MSC */
 		rc = bsc_compl_l3(lchan->conn, msg, 0);
 		if (rc < 0) {
-			gscon_release_lchans(lchan->conn, true);
+			osmo_fsm_inst_dispatch(lchan->conn->fi, GSCON_EV_A_DISC_IND, NULL);
 			return rc;
 		}
 		/* conn shall release lchan on teardown, also if this Layer 3 Complete is rejected. */

-- 
To view, visit https://gerrit.osmocom.org/12174
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iccf5f6864ffe238189907c4bb3ea333948621b4c
Gerrit-Change-Number: 12174
Gerrit-PatchSet: 3
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181206/f848ada0/attachment.htm>


More information about the gerrit-log mailing list