Change in osmo-msc[master]: make gsup ipa name configurable in osmo-msc.cfg

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Stefan Sperling gerrit-no-reply at lists.osmocom.org
Thu Dec 6 18:51:45 UTC 2018


Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12177 )

Change subject: make gsup ipa name configurable in osmo-msc.cfg
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.osmocom.org/#/c/12177/2/src/libmsc/gsm_04_08.c
File src/libmsc/gsm_04_08.c:

https://gerrit.osmocom.org/#/c/12177/2/src/libmsc/gsm_04_08.c@1834
PS2, Line 1834: 	ipa_dev = talloc_zero(net->vlr, struct ipaccess_unit);
> could use a static struct, then no talloc, and no changes in the test expectations? […]
The API says that ipa_dev must be allocated in the same talloc context as the one which ends up as the first argument to osmo_gsup_client_create2().


https://gerrit.osmocom.org/#/c/12177/2/src/libmsc/msc_vty.c
File src/libmsc/msc_vty.c:

https://gerrit.osmocom.org/#/c/12177/2/src/libmsc/msc_vty.c@464
PS2, Line 464:       "Set the IPA name of this MSC.\n"
> "This is transmitted as IPA Serial Number tag, which is used for GSUP routing (e.g. in OsmoHLR). […]
Fixed in next patch set.



-- 
To view, visit https://gerrit.osmocom.org/12177
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I317d6c59f77e92fbb2b875a83dc0ec2fa5cb6006
Gerrit-Change-Number: 12177
Gerrit-PatchSet: 3
Gerrit-Owner: Stefan Sperling <stsp at stsp.name>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <stsp at stsp.name>
Gerrit-Comment-Date: Thu, 06 Dec 2018 18:51:45 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181206/3342d8df/attachment.htm>


More information about the gerrit-log mailing list