Change in osmo-bsc[master]: handover_fsm: send HANDOVER PERFORMED msg on internal ho

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11734 )

Change subject: handover_fsm: send HANDOVER PERFORMED msg on internal ho
......................................................................


Patch Set 7: Code-Review-1

(2 comments)

before, I didn't see the static/non-static issue...

https://gerrit.osmocom.org/#/c/11734/7/src/osmo-bsc/handover_fsm.c
File src/osmo-bsc/handover_fsm.c:

https://gerrit.osmocom.org/#/c/11734/7/src/osmo-bsc/handover_fsm.c@806
PS7, Line 806: 	if (result == HO_RESULT_OK && (ho->scope & HO_INTRA_CELL || ho->scope & HO_INTRA_BSC))
would prefer braces to separate the bitwise from the boolean operators. or 

  (ho->scope & (HO_INTRA_CELL | HO_INTRA_BSC))


https://gerrit.osmocom.org/#/c/11734/7/tests/handover/handover_test.c
File tests/handover/handover_test.c:

https://gerrit.osmocom.org/#/c/11734/7/tests/handover/handover_test.c@223
PS7, Line 223: 	fake_msc_data.network = &fake_bsc_gsmnet;
now a static struct which lives past the invocation of this function references a non-static struct that is discarded at the end of this function. potential segfault! both should be static

  static struct gsm_network fake_bsc_gsmnet = {};
  static struct bsc_msc_data fake_msc_data = { .network = &fake_bsc_gsmnet };

or rather, isn't there a global gsmnet already in this file?



-- 
To view, visit https://gerrit.osmocom.org/11734
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If26e5807280e0f75a423b3b04f8e3c698c82a351
Gerrit-Change-Number: 11734
Gerrit-PatchSet: 7
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 06 Dec 2018 18:23:06 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181206/dabc6836/attachment.htm>