Change in libosmocore[master]: gsm48_generate_mid(): mask out ODD flag from mi_type

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Thu Dec 6 12:23:16 UTC 2018


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12155 )

Change subject: gsm48_generate_mid(): mask out ODD flag from mi_type
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/12155/2/tests/gsm0408/gsm0408_test.c
File tests/gsm0408/gsm0408_test.c:

https://gerrit.osmocom.org/#/c/12155/2/tests/gsm0408/gsm0408_test.c@467
PS2, Line 467: 		.expect_mi_tlv_hex = "17031032f4", /* encoding nonsense! */
It's still an encoding nonsense after this patch? would be nice to understand why is nonsense in the comment.



-- 
To view, visit https://gerrit.osmocom.org/12155
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id6e695ebf9f86b295eaa7e2c6228989256f37e68
Gerrit-Change-Number: 12155
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 06 Dec 2018 12:23:16 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181206/7450c5c8/attachment.htm>


More information about the gerrit-log mailing list