Change in osmo-msc[master]: Store subscriber's cell identity

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Thu Dec 6 11:54:31 UTC 2018


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11746 )

Change subject: Store subscriber's cell identity
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

https://gerrit.osmocom.org/#/c/11746/2/src/libmsc/a_iface_bssap.c
File src/libmsc/a_iface_bssap.c:

https://gerrit.osmocom.org/#/c/11746/2/src/libmsc/a_iface_bssap.c@51
PS2, Line 51: struct osmo_sccp_user *scu, int conn_id)
TBH, this looks ugly. I am not a big fun of such fancy
\t\t\t...\s\s... alignment in general, but let's don't
make it even worse please ;)


https://gerrit.osmocom.org/#/c/11746/2/src/libmsc/a_iface_bssap.c@321
PS2, Line 321: ci = cil.id_list[0].ci;
If 'break' statement is not required here, please add a
comment to suppress possible warnings (e.g. from Coverity).



-- 
To view, visit https://gerrit.osmocom.org/11746
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8544c30ea800ce8356a227b03a8b21bf3252be7e
Gerrit-Change-Number: 11746
Gerrit-PatchSet: 2
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-Comment-Date: Thu, 06 Dec 2018 11:54:31 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181206/e7b206bd/attachment.htm>


More information about the gerrit-log mailing list