Change in osmo-msc[master]: cosmetic: msc_main.c: default args definition style

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Dec 5 19:35:15 UTC 2018


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/12128 )

Change subject: cosmetic: msc_main.c: default args definition style
......................................................................

cosmetic: msc_main.c: default args definition style

Explicitly name each arg with its default value, omit zero values, end last
item in comma.

Change-Id: I0e0f1e2c8722768b6c61fd6544911b20fe1af212
---
M src/osmo-msc/msc_main.c
1 file changed, 3 insertions(+), 5 deletions(-)

Approvals:
  Pau Espin Pedrol: Looks good to me, approved
  Stefan Sperling: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/osmo-msc/msc_main.c b/src/osmo-msc/msc_main.c
index afab417..07e4c8b 100644
--- a/src/osmo-msc/msc_main.c
+++ b/src/osmo-msc/msc_main.c
@@ -96,11 +96,9 @@
 	const char *mncc_sock_path;
 	int use_db_counter;
 } msc_cmdline_config = {
-	"sms.db",
-	"osmo-msc.cfg",
-	0,
-	0,
-	1
+	.database_name = "sms.db",
+	.config_file = "osmo-msc.cfg",
+	.use_db_counter = 1,
 };
 
 /* timer to store statistics */

-- 
To view, visit https://gerrit.osmocom.org/12128
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0e0f1e2c8722768b6c61fd6544911b20fe1af212
Gerrit-Change-Number: 12128
Gerrit-PatchSet: 6
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <stsp at stsp.name>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181205/45fdad4e/attachment.htm>


More information about the gerrit-log mailing list