Change in osmo-bsc[master]: bsc: timeslot_fsm: Fix count in ts_lchans_waiting

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Wed Dec 5 16:06:50 UTC 2018


Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/11983 )

Change subject: bsc: timeslot_fsm: Fix count in ts_lchans_waiting
......................................................................

bsc: timeslot_fsm: Fix count in ts_lchans_waiting

Before this patch, TCH lchans waiting for dynamic TS to
switch PDCH->TCH wouldn't be counted.

See osmo-bsc I9cedb77d6578597f1febab36c54b2ee427c7a4a2 for similar
extensive explanation.

Change-Id: I32008859cc23cd2afddd79daae21497d0945fed0
---
M src/osmo-bsc/timeslot_fsm.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Neels Hofmeyr: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bsc/timeslot_fsm.c b/src/osmo-bsc/timeslot_fsm.c
index 88a8f27..1b77ab2 100644
--- a/src/osmo-bsc/timeslot_fsm.c
+++ b/src/osmo-bsc/timeslot_fsm.c
@@ -144,7 +144,7 @@
 {
 	struct gsm_lchan *lchan;
 	int count = 0;
-	ts_for_each_lchan(lchan, ts)
+	ts_for_each_potential_lchan(lchan, ts)
 		if (lchan->fi->state == LCHAN_ST_WAIT_TS_READY)
 			count++;
 	return count;

-- 
To view, visit https://gerrit.osmocom.org/11983
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I32008859cc23cd2afddd79daae21497d0945fed0
Gerrit-Change-Number: 11983
Gerrit-PatchSet: 6
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Assignee: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181205/db0f9246/attachment.htm>


More information about the gerrit-log mailing list