Change in python/osmo-python-tests[master]: ctrl2cgi: properly limit number of requests

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Wed Dec 5 15:10:55 UTC 2018


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12139 )

Change subject: ctrl2cgi: properly limit number of requests
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.osmocom.org/#/c/12139/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/12139/1//COMMIT_MSG@9
PS1, Line 9: Manual acquire()/release() of semaphore does not limit number of
How did you arrive to this conclusion?


https://gerrit.osmocom.org/#/c/12139/1/scripts/ctrl2cgi.py
File scripts/ctrl2cgi.py:

https://gerrit.osmocom.org/#/c/12139/1/scripts/ctrl2cgi.py@a104
PS1, Line 104: 
Could the issue be that the POST request is sent over here? Can you try moving these 3 lines inside the semaphore.acquire() and release() block?


https://gerrit.osmocom.org/#/c/12139/1/scripts/ctrl2cgi.py@a108
PS1, Line 108: 
The API use looks good to me, according to 
https://twistedmatrix.com/documents/9.0.0/api/twisted.internet.defer.DeferredSemaphore.html



-- 
To view, visit https://gerrit.osmocom.org/12139
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: python/osmo-python-tests
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I47b8b9f5b726ca0905bb7c023d63b325c7f7d85f
Gerrit-Change-Number: 12139
Gerrit-PatchSet: 1
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Comment-Date: Wed, 05 Dec 2018 15:10:55 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181205/23ea889c/attachment.htm>


More information about the gerrit-log mailing list