Change in osmo-msc[master]: make: prepare for adding transcript tests

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Wed Dec 5 14:50:42 UTC 2018


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12126 )

Change subject: make: prepare for adding transcript tests
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/#/c/12126/1/tests/Makefile.am
File tests/Makefile.am:

https://gerrit.osmocom.org/#/c/12126/1/tests/Makefile.am@73
PS1, Line 73: 	if [ -z "$(PYTHON)" ]; then echo "ERROR: python not configured, for manual invocation use 'make PYTHON=/usr/bin/python'"; exit 1; fi
> will do (interesting, I thought there were problems with python shebang on some systems so I figured […]
just make sure that if python 2 is to be used, the shebang contains "python2" and not "python", that's all.


https://gerrit.osmocom.org/#/c/12126/1/tests/Makefile.am@84
PS1, Line 84: 	$(MAKE) ctrl-python-test
> yes, but like above:  […]
Please do, otherwise somebody may end up changing it.



-- 
To view, visit https://gerrit.osmocom.org/12126
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I688657e56ae469c07b9f25ba37275d38dbd457e2
Gerrit-Change-Number: 12126
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 05 Dec 2018 14:50:42 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181205/0bbe827b/attachment.htm>


More information about the gerrit-log mailing list