Change in osmo-bsc[master]: Add VTY option to avoid sending empty Full BCCH Info for disabled SI

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12133 )

Change subject: Add VTY option to avoid sending empty Full BCCH Info for disabled SI
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

Please see my comments. In addition to them, are you sure that
this option is being printed by 'show running-config' and 'write'?

https://gerrit.osmocom.org/#/c/12133/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/12133/1//COMMIT_MSG@27
PS1, Line 27: let's not disable this kind of mesage by
            : default
Here you notice that it isn't enabled by default.


https://gerrit.osmocom.org/#/c/12133/1/src/osmo-bsc/gsm_data.c
File src/osmo-bsc/gsm_data.c:

https://gerrit.osmocom.org/#/c/12133/1/src/osmo-bsc/gsm_data.c@858
PS1, Line 858: bts->si_disabled_send_empty = true;
So this option is enabled by default now, right?



-- 
To view, visit https://gerrit.osmocom.org/12133
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idec1daabc21de4eea5c55edd1dbb0e0775720fc7
Gerrit-Change-Number: 12133
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Wed, 05 Dec 2018 14:09:20 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181205/34d63c75/attachment.htm>