This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Pau Espin Pedrol gerrit-no-reply at lists.osmocom.orgPau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12129 ) Change subject: msc_main: mncc: move mncc socket decision to after read_cfg ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/12129/1/src/osmo-msc/msc_main.c File src/osmo-msc/msc_main.c: https://gerrit.osmocom.org/#/c/12129/1/src/osmo-msc/msc_main.c@549 PS1, Line 549: * At first use the internal MNCC by default, may be changed later according to cfg or cmdline option. */ Please define better "later". From what I see in this change, it's "later in this function", right? This is helpful to confuse reader going to look into other code places (like VTY code, etc.). -- To view, visit https://gerrit.osmocom.org/12129 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifc87c1cacaa809d04fc23e8ccd761bee4509c805 Gerrit-Change-Number: 12129 Gerrit-PatchSet: 1 Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Comment-Date: Wed, 05 Dec 2018 10:53:41 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181205/4cb20d86/attachment.htm>