Change in osmo-pcu[master]: contrib/jenkins.sh: build and publish manuals

[osmith]

osmith has posted comments on this change. ( https://gerrit.osmocom.org/12090 )

Change subject: contrib/jenkins.sh: build and publish manuals
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/12090/1/contrib/jenkins.sh
File contrib/jenkins.sh:

https://gerrit.osmocom.org/#/c/12090/1/contrib/jenkins.sh@8
PS1, Line 8: # * PUBLISH: upload manuals after building if set to "1" (ignored without WITH_MANUALS = "True")
> you know, it's really weird to have all variables as "True" except one being "1". […]
Right. Well, I thought since it is already used that way, that this is how it needs to be done. However, it is only used *once* already, and that is with osmo-pcu.

I found that it was changed from yes/no to True/False here:

https://gerrit.osmocom.org/#/c/osmo-ci/+/5770/2/jobs/gerrit-verifications.yml

But as you commented there, with values in quotes, Jenkins should not convert them to True/False anymore. I will change it to "0" and "1" to make it consistent.



-- 
To view, visit https://gerrit.osmocom.org/12090
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5b112fc1663b78800d3c2c4ff2a0771cf5af11b
Gerrit-Change-Number: 12090
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Wed, 05 Dec 2018 10:38:15 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181205/ecaf7ad4/attachment.htm>