Change in osmo-bsc[master]: bsc: Add define for ts_as_pchan_for_each_lchan with ts->pchan_on_init

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Tue Dec 4 17:00:19 UTC 2018


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11980 )

Change subject: bsc: Add define for ts_as_pchan_for_each_lchan with ts->pchan_on_init
......................................................................


Patch Set 3: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/#/c/11980/3/include/osmocom/bsc/gsm_data.h
File include/osmocom/bsc/gsm_data.h:

https://gerrit.osmocom.org/#/c/11980/3/include/osmocom/bsc/gsm_data.h@483
PS3, Line 483:  * Iterate all lchan instances set up by this \ref ts type, including those
again this is not a doxygen comment (no '/*!' in the start) but still you're using \ref. I'd just drop the doxygen formatting altogether. But doesn't matter much either.



-- 
To view, visit https://gerrit.osmocom.org/11980
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1d4bdbfca6b9719f54ee609b6bfadf7f3a4bb43
Gerrit-Change-Number: 11980
Gerrit-PatchSet: 3
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Assignee: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Tue, 04 Dec 2018 17:00:19 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181204/12b7bc16/attachment.htm>


More information about the gerrit-log mailing list