Change in libosmocore[master]: Logging: don't print hex category by default

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Tue Dec 4 11:46:16 UTC 2018


Max has uploaded this change for review. ( https://gerrit.osmocom.org/12095


Change subject: Logging: don't print hex category by default
......................................................................

Logging: don't print hex category by default

This information is of little use and unnecessarily confuse users. We
also unset it while testing internally. Let's not set this option by
default and let applications enable it explicitly if necessary.

Change-Id: I6dc3898958cf60147ad73c52cf0b3990bd26359e
---
M src/application.c
M tests/logging/logging_vty_test.c
2 files changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/95/12095/1

diff --git a/src/application.c b/src/application.c
index 19e089b..01fda6f 100644
--- a/src/application.c
+++ b/src/application.c
@@ -138,6 +138,7 @@
 
 	log_add_target(std);
 	log_set_all_filter(std, 1);
+	log_set_print_category_hex(std, 0);
 
 	return std;
 }
diff --git a/tests/logging/logging_vty_test.c b/tests/logging/logging_vty_test.c
index 0bdb11d..b177e31 100644
--- a/tests/logging/logging_vty_test.c
+++ b/tests/logging/logging_vty_test.c
@@ -255,7 +255,6 @@
 	osmo_talloc_vty_add_cmds();
 
 	log_set_print_category(osmo_stderr_target, 1);
-	log_set_print_category_hex(osmo_stderr_target, 0);
 	log_set_print_level(osmo_stderr_target, 1);
 	log_set_print_filename2(osmo_stderr_target, LOG_FILENAME_NONE);
 

-- 
To view, visit https://gerrit.osmocom.org/12095
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6dc3898958cf60147ad73c52cf0b3990bd26359e
Gerrit-Change-Number: 12095
Gerrit-PatchSet: 1
Gerrit-Owner: Max <msuraev at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181204/df5711af/attachment.htm>


More information about the gerrit-log mailing list