Change in libosmocore[master]: LCLS, TS 29.205: add GCR routines

[Harald Welte]

Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11827 )

Change subject: LCLS, TS 29.205: add GCR routines
......................................................................


Patch Set 14:

(3 comments)

https://gerrit.osmocom.org/#/c/11827/14/include/osmocom/gsm/gsm29205.h
File include/osmocom/gsm/gsm29205.h:

https://gerrit.osmocom.org/#/c/11827/14/include/osmocom/gsm/gsm29205.h@33
PS14, Line 33: struct gsm29205_gcr {
the name doesn't really indicate whether it's a structure as used in the spec (encoded data) or some parsed representation.  using _parsed as suffix would make it clear.  Also, if things are osmo_ prefixed and not gsmXXXX prefixed, there's less likelihood somebody thinks this represents encoded "on the wire" data.


https://gerrit.osmocom.org/#/c/11827/14/include/osmocom/gsm/gsm29205.h@40
PS14, Line 40: uint8_t gsm29205_enc_gcr(struct msgb *msg, const struct gsm29205_gcr *g);
use osmo_ prefix for all new symbols introduced in osmocom libraries.  the struct above should also be prefixed.


https://gerrit.osmocom.org/#/c/11827/14/tests/gsm29205/gsm29205_test.c
File tests/gsm29205/gsm29205_test.c:

https://gerrit.osmocom.org/#/c/11827/14/tests/gsm29205/gsm29205_test.c@2
PS14, Line 2: S
sysmocom, not Sysmocom



-- 
To view, visit https://gerrit.osmocom.org/11827
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee95aa4e5c056645b6cb5667e4a067097d52dfbf
Gerrit-Change-Number: 11827
Gerrit-PatchSet: 14
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 03 Dec 2018 16:16:41 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181203/631d723d/attachment.htm>