Change in osmo-ci[master]: master-builds/gerrit: remove redundant GTP="$GTP"

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

osmith gerrit-no-reply at lists.osmocom.org
Mon Dec 3 16:11:03 UTC 2018


osmith has posted comments on this change. ( https://gerrit.osmocom.org/12084 )

Change subject: master-builds/gerrit: remove redundant GTP="$GTP"
......................................................................


Patch Set 1:

This patch resulted from the discussion here:
https://gerrit.osmocom.org/#/c/osmo-ci/+/12045/

I gave an example of why this is redundant, repeating it below.

---

I'm sure that it is redundant. See the osmo-trx section from master-builds.yml for example. Currently in master, we have this code:

      - osmo-trx:
          a1_name: INSTR
          # ARM variants temporarily disabled due to issue OS#3061
          # a1: !!python/tuple [--with-sse, --with-neon, --with-neon-vfpv4]
          a1: !!python/tuple [--with-sse]
          concurrent: true
          cmd: ./contrib/jenkins.sh --publish


So there's no INSTR="$INSTR" statement in front of jenkins.sh. The jenkins.sh script of osmo-trx.git has the following line:

  ./configure --enable-sanitize --enable-werror --with-uhd --with-usrp1 --with-lms $INSTR

And executed by jenkins, it it shows that INSTR holds --with-sse:

  + ./configure --enable-sanitize --enable-werror --with-uhd --with-usrp1 --with-lms --with-sse

https://jenkins.osmocom.org/jenkins/view/master/job/master-osmo-trx/710/INSTR=--with-sse,a2=default,a3=default,label=osmocom-master-debian9/console


-- 
To view, visit https://gerrit.osmocom.org/12084
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9238da3dd3c4461f82dc7c792f886177399be3dc
Gerrit-Change-Number: 12084
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Mon, 03 Dec 2018 16:11:03 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181203/bebbafc6/attachment.htm>


More information about the gerrit-log mailing list