Change in osmo-pcu[master]: contrib/jenkins.sh: build and publish manuals

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Dec 3 13:10:10 UTC 2018


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12046 )

Change subject: contrib/jenkins.sh: build and publish manuals
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/12046/2/contrib/jenkins.sh
File contrib/jenkins.sh:

https://gerrit.osmocom.org/#/c/12046/2/contrib/jenkins.sh@74
PS2, Line 74: if [ "$WITH_MANUALS" = "True" ]; then
I think the permutations of --publish and WITH_MANUALS need to be explained somewhere. Maybe in a comment on top?

(Also thinking, maybe also use an env var instead of --publish, a bit weird to use two different ways to pass options for the same kind-of-thing)



-- 
To view, visit https://gerrit.osmocom.org/12046
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id460a932431b46b88937d96637edd209ca56db97
Gerrit-Change-Number: 12046
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-CC: Holger Freyther <holger at freyther.de>
Gerrit-Comment-Date: Mon, 03 Dec 2018 13:10:10 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181203/3857a6f9/attachment.htm>


More information about the gerrit-log mailing list