Change in osmo-trx[master]: lms: Fix start after stop of device

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Mon Dec 3 13:04:14 UTC 2018


Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/12061 )

Change subject: lms: Fix start after stop of device
......................................................................

lms: Fix start after stop of device

Change-Id: I56358a1d1601853bc6dd2e6bb5f80798d0ba84b2
---
M Transceiver52M/device/lms/LMSDevice.cpp
1 file changed, 6 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved



diff --git a/Transceiver52M/device/lms/LMSDevice.cpp b/Transceiver52M/device/lms/LMSDevice.cpp
index 1cda4f9..cb5e31d 100644
--- a/Transceiver52M/device/lms/LMSDevice.cpp
+++ b/Transceiver52M/device/lms/LMSDevice.cpp
@@ -213,6 +213,11 @@
 
 	unsigned int i;
 
+	if (started) {
+		LOGC(DDEV, ERR) << "Device already started";
+		return false;
+	}
+
 	/* configure the channels/streams */
 	for (i=0; i<chans; i++) {
 		if (LMS_EnableChannel(m_lms_dev, LMS_CH_RX, i, true) < 0)
@@ -277,6 +282,7 @@
 		LMS_EnableChannel(m_lms_dev, LMS_CH_TX, i, false);
 	}
 
+	started = false;
 	return true;
 }
 

-- 
To view, visit https://gerrit.osmocom.org/12061
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I56358a1d1601853bc6dd2e6bb5f80798d0ba84b2
Gerrit-Change-Number: 12061
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181203/bd7b2d80/attachment.htm>


More information about the gerrit-log mailing list