Change in osmo-trx[master]: lms: Set Rx gain to midpoint, as comment suggests.

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sun Dec 2 09:24:22 UTC 2018


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/12007 )

Change subject: lms: Set Rx gain to midpoint, as comment suggests.
......................................................................

lms: Set Rx gain to midpoint, as comment suggests.

So far, the Rx gain was set to 34 dB, wile the comment stated it
would be set to half-point, which is 73/2=36dB.  Let's adjust the
code to match the comment.

Change-Id: Idc646def53b83faf4e6c011fb595fa436e223b32
---
M Transceiver52M/device/lms/LMSDevice.cpp
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Pau Espin Pedrol: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/Transceiver52M/device/lms/LMSDevice.cpp b/Transceiver52M/device/lms/LMSDevice.cpp
index 0a6c4a2..1cda4f9 100644
--- a/Transceiver52M/device/lms/LMSDevice.cpp
+++ b/Transceiver52M/device/lms/LMSDevice.cpp
@@ -223,7 +223,7 @@
 
 		// Set gains to midpoint
 		setTxGain((minTxGain() + maxTxGain()) / 2, i);
-		setRxGain(34.0, i);
+		setRxGain((minRxGain() + maxRxGain()) / 2, i);
 
 		m_lms_stream_rx[i] = {};
 		m_lms_stream_rx[i].isTx = false;

-- 
To view, visit https://gerrit.osmocom.org/12007
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Idc646def53b83faf4e6c011fb595fa436e223b32
Gerrit-Change-Number: 12007
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181202/ee67f771/attachment.htm>


More information about the gerrit-log mailing list