Change in osmo-bts[master]: measurement: fix is_meas_overdue() and increase testcoverage

[Harald Welte]

Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10654 )

Change subject: measurement: fix is_meas_overdue() and increase testcoverage
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/#/c/10654/1/src/common/measurement.c
File src/common/measurement.c:

https://gerrit.osmocom.org/#/c/10654/1/src/common/measurement.c@122
PS1, Line 122: static const uint8_t tchf_meas_rep_fn104[] = {
I suggest to name them sdcch*_meas_re_fn102_by_ts[] or _by_tn[]  to make it clear what the index is.  Makes the code more readable.


https://gerrit.osmocom.org/#/c/10654/1/src/common/measurement.c@167
PS1, Line 167: sdcch8_meas_rep_fn102
I suggest to name them sdcch*_meas_re_fn102_by_ss[] or _by_subslot[] to make it clear what the index is.  Makes the code more readible.



-- 
To view, visit https://gerrit.osmocom.org/10654
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d555a21003943bf720c53f3a611029ba45339a9
Gerrit-Change-Number: 10654
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Comment-Date: Tue, 28 Aug 2018 15:20:52 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180828/66be7448/attachment.htm>